<html>
<head><meta charset="utf-8"><title>surpress tidy too many lines warning · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/surpress.20tidy.20too.20many.20lines.20warning.html">surpress tidy too many lines warning</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="223317777"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/surpress%20tidy%20too%20many%20lines%20warning/near/223317777" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/surpress.20tidy.20too.20many.20lines.20warning.html#223317777">(Jan 20 2021 at 00:46)</a>:</h4>
<p>My PR <a href="https://github.com/rust-lang/rust/runs/1726340545">failed tidy</a> because of </p>
<div class="codehilite"><pre><span></span><code>Found 0 error codes with no tests
Done!
tidy error: /checkout/compiler/rustc_lint_defs/src/builtin.rs: too many lines (3039) (add `// ignore-tidy-filelength` to the file to suppress this error)
some tidy checks failed
</code></pre></div>
<p>that file feels like would keep growing, should I just add the ignore tidy, or is there a reason not to?</p>



<a name="223317831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/surpress%20tidy%20too%20many%20lines%20warning/near/223317831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/surpress.20tidy.20too.20many.20lines.20warning.html#223317831">(Jan 20 2021 at 00:47)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span> I would add the ignore unless it's easy to fix</p>



<a name="223317834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/surpress%20tidy%20too%20many%20lines%20warning/near/223317834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/surpress.20tidy.20too.20many.20lines.20warning.html#223317834">(Jan 20 2021 at 00:47)</a>:</h4>
<p><a href="https://github.com/sexxi-goose/rust/blob/migrations_1/compiler/rustc_lint_defs/src/builtin.rs">https://github.com/sexxi-goose/rust/blob/migrations_1/compiler/rustc_lint_defs/src/builtin.rs</a></p>



<a name="223317877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/surpress%20tidy%20too%20many%20lines%20warning/near/223317877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/surpress.20tidy.20too.20many.20lines.20warning.html#223317877">(Jan 20 2021 at 00:48)</a>:</h4>
<p>normally the fix is splitting up the file, which you don't want to mix with other changes</p>



<a name="223317893"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/surpress%20tidy%20too%20many%20lines%20warning/near/223317893" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/surpress.20tidy.20too.20many.20lines.20warning.html#223317893">(Jan 20 2021 at 00:48)</a>:</h4>
<p>doubt there is an easy fix, it's just a lot of docstrings for all the builtin lints</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>